Allow loading executor modules from the fileserver#51427
Merged
dwoz merged 1 commit intosaltstack:developfrom Feb 22, 2019
Merged
Allow loading executor modules from the fileserver#51427dwoz merged 1 commit intosaltstack:developfrom
dwoz merged 1 commit intosaltstack:developfrom
Conversation
Contributor
Author
|
The pylint warning is caused by reserved |
Contributor
Author
|
Waiting several months for the Neon release seems too long. Is it possible to get this merged into 2019.2.1? If so, I can rebase against 2019.2 |
Contributor
|
@saltstack/team-core can yall take a look at this? |
Contributor
|
I will approve this for Neon, lets discuss moving it to 2019.2.1 after the release of 2019.2.0, but we should avoid feature additions to point releases, it really bites us when we do that |
thatch45
approved these changes
Feb 5, 2019
Contributor
thatch45
left a comment
thatch45
left a comment
There was a problem hiding this comment.
This looks good, just as it should!
terminalmage
approved these changes
Feb 5, 2019
Contributor
|
@max-arnold Please have a look at the linter, it is complaining about |
Contributor
Author
|
@dwoz Already did, see my second comment. If you want, I can fix it in a separate commit. |
max-arnold
force-pushed
the
loadable-executors
branch
from
98e8ef7 to
ea9edb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow loading executor modules from the
_executorsfileserver directory. This allows overloading standard executors and also adding new ones to wrap state execution calls globally.Tests written?
Yes
Commits signed with GPG?
No