2019.2: bug: executors lazyloader is missing functions and proxy args#52773
2019.2: bug: executors lazyloader is missing functions and proxy args#52773waynew merged 10 commits intosaltstack:2019.2from
Conversation
these are needed for this functionality to work, otherwise the dunders are not available to generated executors.
|
@mattp- thanks for the PR! Is there a test that this fixes, or would it be possible to throw together a regression test? |
|
the bug is only seen in the sudo executor in core, for which there are no tests. I am working on a replacement implementation of that executor that doesn't rely on sudo but it is not ready for upstream |
|
@waynew i worked out adding an integration test that exercises the bug, however I can't backport it to #52772 because it relies on salt-call having --module-executors via salt-call, which is new functionality added elsewhere in 2019. while doing this i uncovered that executors weren't actually exposed via saltutil.sync* in runner & module, so added that in both pr's. looks like serializer was also added in 2019 but not 2018, so i added it there as well in the other PR. |
|
@waynew clean now. py3 windows seems hung from unrelated issue, but py2 windows passed along with the others. |
|
Looks like last couple passed, just waiting on this current build to finish |
|
Oi. Looks like this is out of date again 😜 |
|
something seems wrong with that win2k16 build, its been running for 2 hours. I'll update branch maybe it will pass this time |
|
@waynew clean now |
|
I'm pretty sure this could cause some conflicts during a forward-merge, because I added |
2019.2: bug: executors lazyloader is missing functions and proxy args
4 participants
What does this PR do?
these are needed for this functionality to work
Tests written?
should be covered by existing tests
Commits signed with GPG?
no
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.