core.py: ignore wrong product_name files

[aplanas]

Some firmwares (like some NUC machines), do not provide valid
/sys/class/dmi/id/product_name strings. In those cases an
UnicodeDecodeError exception happens.

This patch ignore this kind of issue during the grains creation.

[aplanas]

Added tests and remove duplicate dead code for AIX (maybe comes from a wrong rebase in the merge-forward mega PR : (( )

[Ch3LL]

can you take a look at the lint failures and clean those up?

[aplanas]

@Ch3LL indeed, done

[Ch3LL]

ping @dwoz bump can you review?

[aplanas]

The ci/lint complain is a bit weird, as complains for some code that this PR do not touch:

14:06:56  ************* Module salt.grains.core
14:06:56  salt/grains/core.py:51: [W1505(deprecated-method), linux_distribution] Using deprecated method _deprecated_linux_distribution()

[Ch3LL]

ping @s0undt3ch any ideas why we aren't only checking the lines changed here? I checked the settings in noxfile and it looks like we are just running pylint against the files changed, not the lines changed.

[waynew]

@Ch3LL IIUC we've always been doing that, since before nox. I know I've had to fix code in unchanged parts of files that I've touched. I tried running pylint against our whole codebase once and it came up with hundreds, if not thousands of errors and warnings.

I'm not sure if a) we should keep it as-is, b) it's possible/we should change it to ignore untouched lines, or c) we should make a massive lint fix.

My initial impression is that a) is a fine approach.... but this PR is definitely not the place for a discussion about that :)

[s0undt3ch]

PyLint is not capable of checking changed lines.
I'm on my phone so I can't see right away, but I bet this is against develop.
If that's the cases, I started to clean the hundreds of lint errors(because I had to upgrade PyLint due to switching to py3 only, and also because I removed some of the ignores), but that work is not yet complete.
So, expect lint issues, and please fix if so inclided, on PRs against develop.
I'll try to get that work completed once I'm back from PTO.

[s0undt3ch]

By fix, I mean not all of the lint issues, just the ones triggered on PRs on the changed files.

[Ch3LL]

thanks for the clarifications, i was mistaken and thought we were previously doing this.

I put a PR in here: #54163 to ignore this pylint warning

[aplanas]

Rebased into master

[Ch3LL]

ping @waynew can you re-review here?