(Backport 53326) core.py: ignore wrong product_name files#53441
Closed
aplanas wants to merge 2 commits into
Closed
(Backport 53326) core.py: ignore wrong product_name files#53441aplanas wants to merge 2 commits into
aplanas wants to merge 2 commits into
Conversation
twangboy
approved these changes
Jun 14, 2019
aplanas
force-pushed
the
backport_53326
branch
from
89bef3c to
2ac809f
Compare
ghost
requested a review
from 
DmitryKuzmenko
approved these changes
Aug 23, 2019
Some firmwares (like some NUC machines), do not provide valid /sys/class/dmi/id/product_name strings. In those cases an UnicodeDecodeError exception happens. This patch ignore this kind of issue during the grains creation. (cherry picked from commit 35a0c1cd20297479f83a2564dbece3145c0e5a3d)
(cherry picked from commit 56196b739314b19433a6b8d5acbf96d9c70f1bc1)
aplanas
force-pushed
the
backport_53326
branch
from
2ac809f to
a21105f
Compare
Contributor
Author
|
Rebased on master as part of #53441 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some firmwares (like some NUC machines), do not provide valid
/sys/class/dmi/id/product_name strings. In those cases an
UnicodeDecodeError exception happens.
This patch ignore this kind of issue during the grains creation.
(backport #53326)