Fix executors not being called for multi-jobs#53844
Closed
andzn wants to merge 3 commits intosaltstack:2019.2from
Closed
Fix executors not being called for multi-jobs#53844andzn wants to merge 3 commits intosaltstack:2019.2from
andzn wants to merge 3 commits intosaltstack:2019.2from
Conversation
ghost
requested a review
from 
rares-pop
approved these changes
Jul 12, 2019
DmitryKuzmenko
approved these changes
Jul 12, 2019
thatch45
approved these changes
Jul 12, 2019
Akm0d
approved these changes
Jul 12, 2019
Contributor
Author
|
Closing this one in favor of #58040 which targets the master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug where custom executors were not being called for multi-jobs. This PR is based on 2019.2 and also includes a test. There's another PR based on the 2018.3 branch that doesn't contain a test, because the base class for executors integration tests was only added in 2019.3.
What issues does this PR fix or reference?
Previous Behavior
Executors were not being called for multi-jobs
New Behavior
Executors are now called for multi-jobs as well as for single function jobs
Tests written?
Yes
Commits signed with GPG?
No