Fix executors not being called for multi-jobs#52939
Fix executors not being called for multi-jobs#52939andzn wants to merge 4 commits intosaltstack:2018.3from
Conversation
rares-pop
left a comment
rares-pop
left a comment
There was a problem hiding this comment.
Is there a test to 'patch' or can we write a new one to ensure things happens the way we expect, having custom executors set-up?
|
|
||
| salt.utils.process.appendproctitle('{0}._thread_return {1}'.format(cls.__name__, data['jid'])) | ||
|
|
||
| executors = data.get('module_executors') or opts.get('module_executors', ['direct_call']) |
There was a problem hiding this comment.
The setup for this function seems very similar if not identical with _thread_multi_return. Maybe it's worth refactoring that too?
There was a problem hiding this comment.
True. But this code was also touched in develop so I tried to keep the changes to a minimum so that the merging to 2019.2 would not be a head-ache.
#52773 is adding an executor integration test. I can add a new test there once that gets in. However that's only in the 2019.2 branch. |
|
👍 nice add |
|
I created a new PR #53844 based on the 2019.2 branch that also contains a test. |
4 participants
What does this PR do?
Fixes a bug where custom executors were not being called for multi-jobs
What issues does this PR fix or reference?
Previous Behavior
Executors were not being called for multi-jobs
New Behavior
Executors are now called for multi-jobs as well as for single function jobs
Tests written?
No
Commits signed with GPG?
No