Fix sources.list multi-arch definition#62134
Fix sources.list multi-arch definition#62134Ch3LL merged 4 commits intosaltstack:freezefrom babs:hotfix/sourcelist-mutliarch
Conversation
|
@waynew would it be possible to have a quick review on that ? |
|
this PR fixes #62247 |
|
As discussed yesterday, I've rebased it on freeze. |
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - exit code: 1 Thanks again! |
1 similar comment
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - exit code: 1 Thanks again! |
What does this PR do?
This PR fixes a bug in multi-arch sources.list generation
What issues does this PR fix or reference?
Currently, multi-arch definition are generated using space as separator
Multi-arch definition should be comma separated
ex: deb [arch=amd64,i386] http://uk.archive.ubuntu.com/ubuntu/ quantal main universe
https://wiki.debian.org/Multiarch/HOWTO
Commits signed with GPG?
No
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.