Fixes #62662 [BUG] apt pkgrepo.managed signed-by and test=true is messed up#62663
Fixes #62662 [BUG] apt pkgrepo.managed signed-by and test=true is messed up#62663Ch3LL merged 4 commits intosaltstack:freezefrom babs:fix-62662-signed-by-test-true
Conversation
|
There are test failures related to this PR. I would like to try to get this into the 3005.1 release if possible, can you point this PR to the |
|
It seems that test doesn't pass against freeze. |
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - exit code: 1 Thanks again! |
1 similar comment
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - exit code: 1 Thanks again! |
What does this PR do?
What issues does this PR fix or reference?
Fixes: #62662
Previous Behavior
pkgrepo.managedwithsigned-byoption and called withtest=truehas a buggy outputNew Behavior
Issue is fixed
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.