Skip to content

Fixes #62662 [BUG] apt pkgrepo.managed signed-by and test=true is messed up#62663

Merged
Ch3LL merged 4 commits intosaltstack:freezefrom
babs:fix-62662-signed-by-test-true
Sep 15, 2022
Merged

Fixes #62662 [BUG] apt pkgrepo.managed signed-by and test=true is messed up#62663
Ch3LL merged 4 commits intosaltstack:freezefrom
babs:fix-62662-signed-by-test-true

Conversation

@babs
Copy link
Copy Markdown
Contributor

@babs babs commented Sep 12, 2022

What does this PR do?

What issues does this PR fix or reference?

Fixes: #62662

Previous Behavior

pkgrepo.managed with signed-by option and called with test=true has a buggy output

New Behavior

Issue is fixed

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

@babs babs requested a review from a team as a code owner September 12, 2022 19:13
@babs babs requested review from waynew and removed request for a team September 12, 2022 19:13
@whytewolf whytewolf added needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases needs-changelog labels Sep 12, 2022
@whytewolf whytewolf self-requested a review September 12, 2022 19:45
@Ch3LL
Copy link
Copy Markdown
Contributor

Ch3LL commented Sep 14, 2022

There are test failures related to this PR.

I would like to try to get this into the 3005.1 release if possible, can you point this PR to the freeze branch and then I'll review. Thanks :)

@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label Sep 14, 2022
@babs babs changed the base branch from master to freeze September 14, 2022 16:26
@babs babs requested a review from s0undt3ch as a code owner September 14, 2022 16:26
@babs babs changed the base branch from freeze to master September 14, 2022 16:27
@babs babs changed the base branch from master to freeze September 14, 2022 16:38
@babs
Copy link
Copy Markdown
Contributor Author

babs commented Sep 14, 2022

@Ch3LL , I think it's ok
On the same topic, #62134 might also worth merging too (also a source list issue) ?

@babs
Copy link
Copy Markdown
Contributor Author

babs commented Sep 14, 2022

It seems that test doesn't pass against freeze.
I'll take a look

@github-actions
Copy link
Copy Markdown

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- exit code: 1

/home/runner/.cache/pre-commit/repo_6m6ibaj/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:33: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")
The function 'expand_repo_def' on 'salt/modules/aptpkg.py' does not have a 'CLI Example:' in its docstring
Found 1 errors


Thanks again!

1 similar comment
@github-actions
Copy link
Copy Markdown

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- exit code: 1

/home/runner/.cache/pre-commit/repo_6m6ibaj/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:33: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")
The function 'expand_repo_def' on 'salt/modules/aptpkg.py' does not have a 'CLI Example:' in its docstring
Found 1 errors


Thanks again!

@whytewolf whytewolf removed needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases needs-changelog labels Sep 14, 2022
@Ch3LL Ch3LL merged commit aada0ee into saltstack:freeze Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Phosphorus v3005.0 Release code name and version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] apt pkgrepo.managed signed-by and test=true is messed up

4 participants