Update pythonnet to 3.0.1 to support Python 3.10#63355
Merged
Merged
Conversation
Contributor
|
pre-commit is failing |
Contributor
|
re-run full all |
Contributor
|
@twangboy the windows failures are valid and likely due to the new library version. |
Contributor
Author
|
Yeah, pre-commit doesn't run on Windows so I have to do all this stuff by hand. |
Contributor
The windows tests don't start with this new version. Can you have a look a fix that? |
Contributor
|
Not today, of course 😁 |
Contributor
Author
|
Looks like the new version of pythonnet may have broken one of the grains |
twangboy
force-pushed
the
update_pythonnet
branch
from
cb72d8c to
8571f4b
Compare
twangboy
force-pushed
the
update_pythonnet
branch
from
8571f4b to
70a4ee6
Compare
s0undt3ch
approved these changes
Jan 4, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates pythonnet to 3.0.1 to support python 3.10 on Windows
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes