fix: percent-encode userinfo in add_http_basic_auth - #69457
Open
zza-830 wants to merge 2 commits into
Open
Conversation
RFC 3986 section 3.2.1 requires userinfo (user/password) to be percent-encoded. Passwords containing special characters were not encoded, causing URL parsing errors. Now uses urllib.parse.quote on both user and password fields. Fixes saltstack#55561
Adds changelog/55561.fixed.md describing the userinfo percent-encoding fix and reformats tests/unit/utils/test_url.py to match black's line length rules.
twangboy
approved these changes
Jun 30, 2026
Contributor
|
Please create this against the earliest branch where the bug exists, probably 3006.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
add_http_basic_authto percent-encode user and password fields per RFC 3986 §3.2.1.Problem
Passwords containing special characters (
+,/,@,:, etc.) were inserted verbatim into the URL userinfo component. This caused URL parsing errors likePort number ended with 'N'when the password contained these characters.Solution
Uses
urllib.parse.quote()on both user and password fields before constructing the netloc. Alphanumeric characters and-,_,.,~are left unencoded (safe by default inquote()).Example
Fixes #55561