Remove temporary Fedora 40 test skips (#66540, #66539) - #69645
Merged
Conversation
The Fedora 40 skips on test_peer_communication and test_grains_remove_add were added in 5a85699 (2024-05-17) as a temporary workaround referencing saltstack#66539 and saltstack#66540 with no root cause captured. Fedora 40 reached end-of-life on 2025-05-13 and the tests now pass without the workaround on 3007.x and master, so the skips can be dropped. Fixes saltstack#66540 Fixes saltstack#66539
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the temporary Fedora 40 skips added in 5a85699 (2024-05-17) on:
tests/pytests/integration/master/test_peer.py::test_peer_communicationtests/pytests/integration/modules/grains/test_append.py::test_grains_remove_addFedora 40 reached upstream EOL on 2025-05-13 and a repro run against 3007.x
and master confirms the tests now pass without the skip. Fedora 40 remains
in the CI matrix (
cicd/shared-gh-workflows-context.yml); dropping it thereis a separate housekeeping change.
What issues does this PR fix or reference?
Fixes #66540
Fixes #66539
Previous Behavior
test_peer_communicationandtest_grains_remove_addskipped unconditionallyon Fedora >= 40 with the message "Temporary skip on {osfinger}". The original
commit landed as a workaround with no root cause captured, and the skips have
persisted on 3007.x, 3008.x, and master.
New Behavior
Both tests run on Fedora 40 (and any future Fedora >= 40 image that lands in
CI). No product code changes; only test-suite skip removal plus the required
changelog entry.
Merge requirements satisfied?
Commits signed with GPG?
Yes