publish-nightly-release: dashboard should update even when release already exists - #70044
Merged
dwoz merged 1 commit intoAug 14, 2026
Merged
Conversation
Only `create release with all assets` isn't idempotent — creating an existing release fails. All other steps (download artifacts, list assets, download junit, extract salt version, checkout gh-pages, regenerate dashboard, commit + push) can safely re-run against an existing release, and the dashboard generator specifically handles same-tag entries by replacing them. Prior gate made the dashboard silently no-op whenever a release already existed (observed: publish-nightly-release run 31784972054 exited in 9s because nightly-2026-08-14-3008.x had been created earlier in the day, so no dashboard was ever generated). Keep the gate on release-create only; drop from every other step.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #70040.
publish-nightly-release.yml's dashboard steps inheritedif: steps.check.outputs.already-exists != 'true'— the same gate that skips release-create when a release for the day/branch already exists. That's wrong for the dashboard: the dashboard should reflect every nightly.yml completion, and the generator already handles same-tag entries by replacing them.Observed on saltstack/salt-nightlies
Publish-nightly-release run 31784972054 fired after nightly.yml 31781506651 completed. But
nightly-2026-08-14-3008.xhad been created earlier in the day by a natural cron cycle, so the release-create step correctly skipped — and every subsequent step (including dashboard generation) skipped too. Result: run exited in 9s,gh-pagesunchanged.Fix
Only
create release with all assetsisn't idempotent — creating an existing release fails, so it correctly needs the gate. All other steps (download artifacts, list assets, download junit, extract salt version, checkout gh-pages, regenerate dashboard, commit + push) can safely re-run:history = [e for e in history if e.get("tag") != args.tag]; history.append(entry)Drop the gate from every non-release step. Small change (7 lines).
What issues does this PR fix or reference?
Follow-up to #70040. No linked issue.
Merge requirements satisfied?
Commits signed with GPG?
No.