Cite the ingest source for the uppercase behaviour - #3
Merged
Conversation
saluc28
commented
Aug 4, 2026
saluc28
commented
Owner
- Drop an unverified claim about MSSQLHound's schema
- Cite the ingest source for the uppercase behaviour
The note called it the only public reference implementation of an extension definition schema. bloodhound-kube publishes one too, in config/schema.json, outside internal/. The reason to pin against MSSQLHound is that its schema comes from the people who define the format, not that it is the only one.
The note rested on an observation against a running instance. ConvertGenericNode uppercases the id on the generic ingest path, at convertors.go:36 in v9.5.1, and the comment beside the line calls it a BloodHound convention. The use_raw_object_id flag would keep the original case, but its migration ships it with enabled and user_updatable both false, so callers cannot turn it on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.