Conversation
…tionBottomSheet UI
…es, and update settings UI labels
… UI components for improved localization support
… pull requests in SettingsActivity
…standardize long-press interaction across UI cards
…s and config items
…rendering across UI components
…e daily wallpaper timer display
…r cycle and periodic retry attempts.
This pull request introduces a comprehensive in-app translation contribution workflow, allowing users to translate app strings, manage translation sessions, and submit or update translation pull requests directly from the app. The changes span the GitHub Actions workflow, ProGuard rules, and the main app UI and logic, with a focus on translation mode and GitHub integration. **Translation Contribution Workflow & UI:** * Added a new "Translations" section in the settings UI, including GitHub authentication, translation mode toggle, session management, and open PR tracking (`SettingsActivity.kt`). [[1]](diffhunk://#diff-576ba73ddab3e3ff415e6dc1c0b3b670b182d923408666f9be5a506cd6f9f5a1R279-R312) [[2]](diffhunk://#diff-576ba73ddab3e3ff415e6dc1c0b3b670b182d923408666f9be5a506cd6f9f5a1R715-R842) [[3]](diffhunk://#diff-576ba73ddab3e3ff415e6dc1c0b3b670b182d923408666f9be5a506cd6f9f5a1R1488-R1525) * Translation mode now displays a badge in the main UI when active, improving user feedback (`MainActivity.kt`). **GitHub Integration:** * Implemented a method in `GitHubRepository` to fetch open translation pull requests for the current user, enabling the app to display and link to existing PRs (`GitHubRepository.kt`). **Workflow Improvements:** * Updated the GitHub Actions workflow for applying translations: - Supports authenticated pushes using a user OAuth token. - Replaces shell scripting with Python for robust XML editing. - Handles updating existing PRs instead of always creating new ones. - Switches PR base branch to `develop` and includes assignee/reviewer fields (`.github/workflows/apply-translations.yml`). [[1]](diffhunk://#diff-a3f7722207a73e6405f04440bc640173b93a9015cd581bab14d7a743ebe3b6efR18-R21) [[2]](diffhunk://#diff-a3f7722207a73e6405f04440bc640173b93a9015cd581bab14d7a743ebe3b6efR32-R116) **Settings & State Management:** * Added persistent suppression for the translation mode warning dialog in `SettingsRepository` (`SettingsRepository.kt`). **Build & Dependency Updates:** * Added ProGuard/R8 rules for SLF4J logging and cleaned up unused comments, ensuring compatibility and smaller APKs (`proguard-rules.pro`). [[1]](diffhunk://#diff-24fc40bbf6fe503c74604e0477ff8f55aeab48cb521e1a844b9efa6c3771c15eL8-L22) [[2]](diffhunk://#diff-24fc40bbf6fe503c74604e0477ff8f55aeab48cb521e1a844b9efa6c3771c15eR53-R56) These changes collectively enable a seamless, user-friendly translation contribution process, integrated with GitHub, and improve both developer and contributor experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive in-app translation workflow for community contributions, focusing on a seamless translation mode, GitHub authentication, and improved management of translation pull requests. It also adds ProGuard rules for SLF4J and cleans up legacy comments. The most important changes are organized below:
In-App Translation Workflow
SettingsActivity, including UI for toggling translation mode, viewing/editing pending translations, and listing open translation pull requests for the signed-in user. This includes integration withTranslationManager, session state, and new bottom sheets for translation sessions, GitHub authentication, and warnings. [1] [2] [3]GitHub Integration
GitHubRepository. [1] [2]apply-translations.yml) to support user-provided OAuth tokens, improved branch and PR management (including updating existing PRs), and switched to a Python script for robust XML string editing. [1] [2]User Experience & Settings
ProGuard & Build
proguard-rules.proand added rules to keep SLF4J classes and suppress warnings, preventing R8 build issues. [1] [2] [3]These changes together enable a robust, user-friendly translation contribution workflow, tightly integrated with GitHub and the app’s settings.