Support Canonical URLs in Search Params#3749
Open
knoppiks wants to merge 1 commit into
Open
Conversation
knoppiks
force-pushed
the
3344-support-canonical-urls-in-search-params
branch
from
6ea3143 to
f39f51a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3749 +/- ##
=======================================
Coverage 96.21% 96.22%
=======================================
Files 422 422
Lines 26350 26444 +94
Branches 642 648 +6
=======================================
+ Hits 25353 25445 +92
Misses 474 474
- Partials 523 525 +2
🚀 New features to boost your workflow:
|
alexanderkiel
requested changes
Jun 29, 2026
| END | ||
| } | ||
|
|
||
| create() { |
Member
There was a problem hiding this comment.
Please use create from util.sh
| valueset "2.1.6" | create | ||
|
|
||
| search() { | ||
| curl -sfH 'Accept: application/fhir+json' -H "Content-Type: application/fhir+json" "$base/ValueSet?url$1=$vs_url$2&_summary=count" | jq -r .total |
Member
There was a problem hiding this comment.
We don't need Content-Type here.
| - name: Search Observation _profile Version | ||
| run: .github/scripts/search-observation-profile-version.sh | ||
|
|
||
| - name: Search ValueSet url version |
Member
There was a problem hiding this comment.
Version should be title case.
knoppiks
force-pushed
the
3344-support-canonical-urls-in-search-params
branch
from
f39f51a to
f7b5415
Compare
knoppiks
force-pushed
the
3344-support-canonical-urls-in-search-params
branch
2 times, most recently
from
b92dc91 to
68f48be
Compare
Closes: #3344 Signed-off-by: Jonas Wagner <jwagner@knoppiks.de>
knoppiks
force-pushed
the
3344-support-canonical-urls-in-search-params
branch
from
68f48be to
97b689e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3344