Update string encoding example with Mark's current location#363
Closed
ThomasColthurst wants to merge 2 commits into
Closed
Update string encoding example with Mark's current location#363ThomasColthurst wants to merge 2 commits into
ThomasColthurst wants to merge 2 commits into
Conversation
yfarjoun
reviewed
Dec 5, 2018
| \vspace{0.3cm} | ||
|
|
||
| Suppose you want to encode the string MarkDePristoWorksAtTheBroad, a string of size 27. | ||
| Suppose you want to encode the string MarkDePristoWorksAtGoogle, a string of size 25. |
Contributor
There was a problem hiding this comment.
This was an annoying idea when first put in, but given his status was strange to comment on....at this point, I think that it should either be left alone, or, if changed, find something that will always be true. possibly NOT pointing to a particular person or company....
Contributor
|
👎 |
Member
💯 agree. “VariantCallFormatSampleText” would suffice and is of the same size as the existing text. Also it would be good to put |
jmarshall
added a commit
to jmarshall/hts-specs
that referenced
this pull request
Mar 7, 2019
In particular, use a string that is not subject to change! Hat tip Thomas Colthurst. Closes samtools#363. Also fix a|b formatting and note that the inline/overflow boundary is >= 15 rather than > 15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.