Skip to content

Conversation

@jacobdr
Copy link
Contributor

@jacobdr jacobdr commented Nov 7, 2022

Adds support for musl-linux targets (like Alpine) to download our NodeJS binaries

Closes #11

  • Downloads musl-x86_64 bits from the NodeJS unofficial releases
  • Adds a note to the README about the sources from which we get our NodeJS release bits
  • Gets rid of a RuntimeWarning emitted when running with python -m nodejs caused by the module import order (and now tested by running in CI with python -W error which turns warnings into thrown exceptions)

@jacobdr
Copy link
Contributor Author

jacobdr commented Nov 10, 2022

@samwillis i know you're busy with other things just wanted to give you a tap when you can to review this

@samwillis
Copy link
Owner

@jacobdr This all looks good, going to merge. Will push new alpha realises to PyPI later too. Thanks!

@samwillis samwillis merged commit 07c0845 into samwillis:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Alpine Linux distro

2 participants