Modal container#368
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
…th new modal styling
songmichael11
added a commit
that referenced
this pull request
Apr 7, 2026
* add review round schema and connect to review * remove references to interview rating + difficulty * typecheck fix * fix test * review choices * prettier * temp typecheck fix * rename reviewround to interviewRound * test commit * temp stuff review form * migration fix * made drafts work * Modal container (#368) * styled model * donut chart * donut values and sort benefits * fixed linting * new modal container * modal * separated role info from modal and replaced collapsable containers with new modal styling * formatting * removed work models * more formatting * removed unused import * change info card to modal container * linting * added modal styling * fixed div * linting * formatting * remove duplicate type * type fix --------- Co-authored-by: Tiffany Uong <uong.t@northeastern.edu> Co-authored-by: tracyyh <huang.tr@northeastern.edu> Co-authored-by: Michael Song <64758303+songmichael11@users.noreply.github.com> Co-authored-by: Michael Song <song.mich@northeastern.edu> * fix merge stuff * we pray * wide screen support * jank mobile stuff * review form mobile responsiveness --------- Co-authored-by: Sarah-Zhang1 <zhang.sarah1@northeastern.edu> Co-authored-by: Tiffany Uong <152104667+Tiffybin@users.noreply.github.com> Co-authored-by: Tiffany Uong <uong.t@northeastern.edu> Co-authored-by: tracyyh <huang.tr@northeastern.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
created a reusable modal container for each part of the roles tab
Motivation and Context
new design
Closes #355
How has this been tested?
I came I saw
Screenshots (if appropriate):
Types of changes
pnpm db:generateand verified generated SQL migration files inpackages/db/drizzleChecklist: