Merged
Conversation
This reverts commit bc38882.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
tracyyh
approved these changes
Mar 15, 2026
Collaborator
There was a problem hiding this comment.
this is not being used in the code rn right?
Comment on lines
-6
to
-7
| export const runtime = "edge"; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Long description:
The google auth stuff for cooper (non localhost) is stored on the Sandbox gmail. I logged into that and added a new auth. This is because we want the regular login to restrict to only husky.neu.edu accounts, but we also want an option for admin/coordinators to log in with a different gmail account.
This new oauth provider allows users to log in with any gmail account. I also added
AUTH_GOOGLE_ADMIN_IDandAUTH_GOOGLE_ADMIN_SECRETto the .env file (ask michael for these values!) and to vercel for both the cooper-auth and cooper deploymentsIf someone tries to log in with a gmail account that isn't already registered as an admin / coordinator, they're redirected back to the landing page and an error message shows up
Logging in with husky.neu.edu works as expected, if not registered, they're redirected to the onboarding page
The user table in the database now has a role column, and
roleis of typestudent,admin, orcoordinator. The exact permissions for these roles haven't been fully fleshed out yet, but as of right now, student is what a normal cooper user can do right now and is the default, coordinator (eg. co-op advisor) has view-only access to see reviews but can't see admin dashboard, and admin can see everything. A coordinator and admin both cannot leave reviews on cooperOn the admin dashboard page, admin can enter in someone's email and select whether they should be admin or coordinator. The database is propagated with that corresponding info, and that new user can now log into cooper with that gmail account
Changes:
MICHAEL DB NOTE:
COOPER DEVS: must run pnpm db:migrate and pnpm db:push since there was a schema change here
Tldr:
made different roles and made an ugly version of the admin dashboard
Motivation and Context
Neu coop people want it
How has this been tested?
I've logged in and out a bunch of times and tried with different roles to make sure it works as expected
Types of changes
pnpm db:generateand verified generated SQL migration files inpackages/db/drizzleChecklist: