[codex] Harden safe registration diagnostics - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RAW_TOOL_FAILEDinstead of being classified asSAFE_TOOL_FAILED.Why
FastMCP Java is a safe MCP registration/wrapping layer over Spring AI, AgentScope, and the underlying MCP SDKs. The production hardening path should make the safe provider the only model-facing tool path, keep reflection compatibility isolated, and make diagnostics and assembly easier to reason about.
Validation
git diff --checkmvn -B testwith JDK 17.0.18mvn -B -Pexamples testwith JDK 17.0.18JAVA_HOME=$(/usr/libexec/java_home -v 11) PATH="$JAVA_HOME/bin:$PATH" mvn -B -pl fastmcp-safe-core,fastmcp-safe-config -am testwith JDK 11.0.30Notes
This PR does not make FastMCP Java implement the MCP protocol itself. The documented production check is about verifying that Spring AI / AgentScope / MCP SDK integrations expose only safe virtual tools to the model.