#250 Add before/after map hooks and PR coverage comments - #281
Merged
Conversation
Introduce the public before/after map hook attributes with unit tests and bump to 10.2.0-alpha.14 so the generator can consume the new API. Co-authored-by: Cursor <cursoragent@cursor.com>
Parse class and method hook attributes, resolve ordered before/after hooks with MP00045/MP00046 diagnostics, and emit root-body invocations around the core mapping strategy. Co-authored-by: Cursor <cursoragent@cursor.com>
Cover hook resolution, ordering, diagnostics, and codegen, including inherited-interface discovery, then publish the generator package for sample consumption. Co-authored-by: Cursor <cursoragent@cursor.com>
Demonstrate class/method hook ordering, context, and per-type class-level resolution with observable mutations. Co-authored-by: Cursor <cursoragent@cursor.com>
Exercise hooks under native AOT and document attributes, algorithm, diagnostics MP00045/MP00046, and samples. Co-authored-by: Cursor <cursoragent@cursor.com>
Show current coverage with trend markers, always mark the latest point, add dashed horizontal guides, and add a local gist-based SVG preview script. Co-authored-by: Cursor <cursoragent@cursor.com>
Draw a same-color regression trend line for line, branch, and method coverage series. Co-authored-by: Cursor <cursoragent@cursor.com>
After tests, compare coverage to gist baseline, comment with trends, warn above 1% drop, and fail above 5%. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
Read MAPPA-CODE-COVERAGE-HISTORY.MD via gh gist view with GH_PAT, matching UpdateCodeCoverageGists.ps1. Co-authored-by: Cursor <cursoragent@cursor.com>
Allow the coverage comment step to read the GH_PAT environment secret for gist access. Co-authored-by: Cursor <cursoragent@cursor.com>
Use GH_PAT only for gist history, GITHUB_TOKEN with gh pr comment --edit-last --create-if-none for posting. Co-authored-by: Cursor <cursoragent@cursor.com>
Code coverageCompared against the latest published coverage history from the code coverage gist.
No coverage metric dropped by more than 1 percentage point(s) versus baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MappaBeforeMap/MappaAfterMapclass- and method-level hooks with ordered resolution, MP00045/MP00046 diagnostics, generator codegen, tests, samples, AOT runner, and docs (alpha.14 → alpha.15).Test plan
Closes #250