#108 Add PreventEnumerableCount MappaSettings option - #285
Merged
sanelli merged 3 commits intoJul 26, 2026
Conversation
Introduce the BooleanSetting surface and bump to 10.2.0-alpha.23 so the generator can consume it. Co-authored-by: Cursor <cursoragent@cursor.com>
Wire the setting through Mappa.Generator, emit growable List buffers instead of Enumerable.Count for single-enumeration sources, add integration and attribute parsing tests, and bump to 10.2.0-alpha.24. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Code coverageCompared against the latest published coverage history from the code coverage gist.
No coverage metric dropped by more than 1 percentage point(s) versus baseline. |
sanelli
deleted the
108-allow-preventing-using-enumerbalecountthis-t-values-when-targeting-arraysspanmemory
branch
July 26, 2026 12:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MappaSettings.PreventEnumerableCount(BooleanSetting, editorconfigmappa.preventenumerablecount) so mappings from sources withoutCount/Lengthto fixed-size targets (T[],Span<T>,Memory<T>, and read-only variants) can avoidEnumerable.Countand enumerate once via a growableList<T>buffer.CollectionToCollectionMapStrategyBuilder, with integration tests (syntax-tree assertions), samples/AOT runner, and docs.10.2.0-alpha.24(after Mappa and generator changes).Test plan
EnumerableConcreteType.Array, editorconfig, and class/method overridesPreventEnumerableCount.\Scripts\RunTestsAndReportCoverage.ps1— line/branch/method ≥ baseline (solution 98.4%/90.6%/100%; Generator branch improved to 90.6%)Closes #108