#290 Improve generator tests and assertion rules - #292
Merged
Conversation
Add HasNextSyntaxNode walks for previously source-count-only generator tests, including NoMap stubs, namespace shapes, multi-mapper units, and queryable projections. Co-authored-by: Cursor <cursoragent@cursor.com>
Assert warning diagnostics via descriptors and message args; remove the HaveOnlyWarnings assertion helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
Require syntax walks after HaveGeneratedSourceCode, prefer HaveDiagnostics/HaveDiagnostic, and increment MappaVersion for CI. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
Closed
Code coverageCompared against the latest published coverage history from the code coverage gist.
No coverage metric dropped by more than 1 percentage point(s) versus baseline. BenchmarksAutoMapper is the BenchmarkDotNet ratio baseline. Absolute values are mean time in nanoseconds and allocated bytes. Ratio columns are competitor / Mappa as a percentage (n/a when either side is missing or Mappa is zero).
Benchmark trends (Mappa)Lower is better. Compared against the latest published Mappa-only rows from MAPPA-BENCHMARK-HISTORY.md.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HasNextSyntaxNodesyntax walks after everyHaveGeneratedSourceCode()(or assert stubs where generation still emits a NoMap return).HaveOnlyWarningswithHaveDiagnostics+HaveDiagnostic(MappaDiagnosticDescriptors.…)and remove the assertion helpers.MappaVersionto10.2.0-alpha.29.Closes #290.
Test plan
dotnet test Mappa.Generator.Tests/Mappa.Generator.Tests.csproj(1877 passed).\Scripts\RunTestsAndReportCoverage.ps1(2652 passed; line 98.4% / branch 90.6% / method 100% ≥ baseline)