Conversation
Replace source-only reference slots with a composite key and generic AddReferencePair so the same source can map to different declared target types without silent overwrite. Bump to 10.2.0-alpha.65. Co-authored-by: Cursor <cursoragent@cursor.com>
…ferencePair. Emit a per-map-method MappaReferenceManager temporary, use generic AddReferencePair, and skip exit registration when early Add or a reusing callee already registered. Update generator integration assertions and builder-context coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
Cover Compatible/Polymorphic method-map omit paths, non-reusing callee exit Add, unconstrained type-parameter eligibility, and before/after hooks with ReferenceReusing. Co-authored-by: Cursor <cursoragent@cursor.com>
…e AddReferencePair args. Bump to alpha.67 after fixing CS8634 for nullable type arguments on AddReferencePair, and document composite-key reuse, manager locals, and early vs exit registration. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
3 tasks
Closed
3 tasks
Code coverageCompared against the latest published coverage history from the code coverage gist.
No coverage metric dropped by more than 1 percentage point(s) versus baseline. |
sanelli
deleted the
320-reference-reuse-define-behavior-when-stored-target-type-does-not-match-trygetreferencet
branch
August 9, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typeof(TTarget); genericAddReferencePair<TTarget,TSource>.AddReferencePairwhen early registration already ran or a reusing callee already registered.GetReferenceManager(context)in one per-method local.alpha.67: strip nullable annotations fromAddReferencePairtype args (CS8634) and document per-TTargetkeying / codegen notes.Test plan
.\Scripts\RunTestsAndReportCoverage.ps1(coverage ≥ baseline: line 98.4%, branch 91%, method 100%).\Scripts\RebuildUponVersionChange.ps1through samples/AOT/benchmarksReferenceReusingCycleBenchmark/ReferenceReusingSharedDagBenchmarkCloses #320
Closes #321
Closes #322