Skip to content

chore(deps): override sanity and @sanity/vision to next - #1821

Merged
stipsan merged 4 commits into
mainfrom
cursor/sanity-next-overrides-8d3c
Aug 3, 2026
Merged

chore(deps): override sanity and @sanity/vision to next#1821
stipsan merged 4 commits into
mainfrom
cursor/sanity-next-overrides-8d3c

Conversation

@stipsan

@stipsan stipsan commented Aug 3, 2026

Copy link
Copy Markdown
Member

Draft PR to exercise plugins against sanity@next and @sanity/vision@next (currently 6.9.0-next.19).

Changes

  • pnpm-workspace.yaml overrides: sanity, @sanity/visionnext
  • Also pins @sanity/mutator, @sanity/schema, @sanity/types, @sanity/util, and groq to next so they stay in lockstep with sanity (required to avoid duplicate Studio package versions / dts emit failures)
  • Lockfile regenerated; minimumReleaseAgeExclude updated for react-rx@5.1.1 (pulled in by sanity@next)
  • Catalog entries left on ^6.7.0 — only overrides force the next dist-tag

Compatibility fix

  • @sanity/color-input: make preview prepare selected fields optional so the schema type is assignable under sanity@next's Record<string, any> prepare typing (TS2322)

Verification

  • pnpm format
  • pnpm lint
  • pnpm knip
  • pnpm build
  • pnpm test run ✅ (211 files / 1280 tests)

Notes

  • Changeset only for the color-input typing fix; the override pin itself is a compatibility test, not a release
  • Intent: verify plugins against the next Studio line before it ships

Intent

Compatibility test only — do not merge until ready to adopt the next channel.

Open in Web Open in Cursor 

Pin the Studio monorepo packages to the `next` dist-tag via pnpm
overrides for compatibility testing. Keep mutator/schema/types/util/groq
in lockstep with sanity to avoid duplicate versions in the lockfile.
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
plugins-studio Ready Ready Preview Aug 3, 2026 3:52pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plugins-e2e-test-studio Ignored Ignored Aug 3, 2026 3:52pm

Request Review

@stipsan stipsan added the 🤖 bot label Aug 3, 2026 — with Cursor
@changeset-bot

changeset-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 29175f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sanity/color-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

✅ E2E Tests

🟢 24 passedview full reportview run

Studio: https://plugins-e2e-test-studio-pctcid71s.sanity.dev

Datasets: pr-1821-chromium-30829464485, pr-1821-firefox-30829464485

Make selected preview fields optional so prepare is assignable under
SchemaTypeDefinition's Record<string, any> value typing in 6.9.0-next.
@socket-security

socket-security Bot commented Aug 3, 2026

Copy link
Copy Markdown

@socket-security

socket-security Bot commented Aug 3, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • npm/@module-federation/sdk@2.8.1

View full report

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 32% 5507 / 17208
🔵 Statements 31.77% 5811 / 18287
🔵 Functions 27.79% 1428 / 5137
🔵 Branches 23.33% 2828 / 12118
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
plugins/@sanity/color-input/src/schemas/color.tsx 30% 0% 0% 33.33% 9, 29-36, 90-97
Generated in workflow #8617 for commit 29175f6 by the Vitest Coverage Report Action

@stipsan

stipsan commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@SocketSecurity ignore npm/@module-federation/sdk@2.8.1

@stipsan

stipsan commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

@stipsan
stipsan marked this pull request as ready for review August 3, 2026 15:43
@stipsan
stipsan requested a review from a team as a code owner August 3, 2026 15:43
@stipsan
stipsan requested review from Copilot and pedrobonamin and removed request for a team August 3, 2026 15:43
Resolve pnpm-lock.yaml conflict by regenerating against merged
pnpm-workspace.yaml (next overrides + @sanity/client ^7.26.0 from main).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the workspace dependency resolution to exercise the monorepo against sanity@next and @sanity/vision@next, regenerating the lockfile accordingly, and includes a small typing adjustment in @sanity/color-input to remain compatible with updated prepare typings in the next channel.

Changes:

  • Pin sanity, @sanity/vision, and related Studio monorepo packages to the next dist-tag via pnpm-workspace.yaml overrides.
  • Regenerate pnpm-lock.yaml to reflect the next resolutions and related dependency graph shifts (incl. react-rx@5.1.1).
  • Adjust @sanity/color-input schema preview prepare typing and add a changeset for the consumer-facing typing fix.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
pnpm-workspace.yaml Updates minimumReleaseAgeExclude and pins core Sanity Studio packages to next via overrides for compatibility testing.
pnpm-lock.yaml Regenerated lockfile reflecting the next overrides and updated dependency graph.
plugins/@sanity/color-input/src/schemas/color.tsx Makes preview prepare selected fields optional and adds a fallback title to satisfy updated typing expectations.
.changeset/color-input-preview-prepare.md Adds a changeset for the @sanity/color-input typing compatibility fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pnpm-workspace.yaml Outdated
Copilot AI review requested due to automatic review settings August 3, 2026 15:46

Copilot AI commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved by merging origin/main and fixing the lockfile conflict in commit abe05ff.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

List each version as its own exact name@version entry per AGENTS.md
instead of a combined || expression.
Copilot AI review requested due to automatic review settings August 3, 2026 15:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

pnpm-workspace.yaml:158

  • The comment says the lockstep override is for mutator/schema/types/util/groq, but this override set also includes @sanity/vision. Updating the comment avoids drift between the doc and the actual overrides.
  # Pin the Sanity Studio monorepo to the `next` dist-tag for compatibility testing.
  # Keep mutator/schema/types/util/groq in lockstep with sanity so dts emit and
  # transitive deps (cli/migrate/portabletext) cannot leave a second major.minor

plugins/@sanity/color-input/src/schemas/color.tsx:96

  • Using title || 'Color' will also replace an intentionally empty string title with the fallback. If an empty string is a valid (even if rare) value here, prefer nullish coalescing so only undefined/null fall back.
      return {
        title: title || 'Color',
        subtitle: subtitle,

@stipsan
stipsan merged commit 1c44147 into main Aug 3, 2026
26 checks passed
@stipsan
stipsan deleted the cursor/sanity-next-overrides-8d3c branch August 3, 2026 17:45
@squiggler-app squiggler-app Bot mentioned this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants