feat: plugin support#28
Merged
Quantumlyy merged 18 commits intomainfrom Aug 25, 2020
Merged
Conversation
Member
|
Is this ready for review or wha? Amount of changes is very... minimal |
Quantumlyy
force-pushed
the
feat/plugins
branch
from
8881045 to
7742808
Compare
kyranet
reviewed
Aug 25, 2020
Quantumlyy
force-pushed
the
feat/plugins
branch
from
fd62759 to
5aeab14
Compare
and still some stuff to do since this is just a start
kyranet
requested changes
Aug 25, 2020
kyranet
requested changes
Aug 25, 2020
kyranet
approved these changes
Aug 25, 2020
vladfrangu
reviewed
Aug 25, 2020
|
|
||
| public static use(plugin: typeof Plugin) { | ||
| this.plugins.use(plugin); | ||
| return SapphireClient; |
Member
There was a problem hiding this comment.
Shouldn't this return.. this
Contributor
Author
There was a problem hiding this comment.
SapphireClient and this are the same in this context. Both return the class.
Member
There was a problem hiding this comment.
If I extend the client, use won't return my client but SapphireClient
Contributor
|
@all-contributors pls add @QuantumlyTangled for code, plugin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.