Skip to content

feat(core): add base i18n handlers#43

Merged
kyranet merged 4 commits intomainfrom
feat/built-in-i18n-support
Aug 28, 2020
Merged

feat(core): add base i18n handlers#43
kyranet merged 4 commits intomainfrom
feat/built-in-i18n-support

Conversation

@kyranet
Copy link
Copy Markdown
Member

@kyranet kyranet commented Aug 28, 2020

Fixes #16

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 28, 2020

Coverage Status

Coverage decreased (-1.9%) to 31.798% when pulling ede2319 on feat/built-in-i18n-support into 1421c05 on main.

@Quantumlyy
Copy link
Copy Markdown
Contributor

Wasn't this supposed to be made a plugin instead of being included in base?

@kyranet
Copy link
Copy Markdown
Member Author

kyranet commented Aug 28, 2020

Wasn't this supposed to be made a plugin instead of being included in base?

¯\_(ツ)_/¯

The linked issue was there for pretty long and nobody commented on it, so I understood it as there were no objections.

Comment thread src/lib/utils/i18n/IInternationalization.ts
Comment thread src/lib/SapphireClient.ts Outdated
favna
favna previously approved these changes Aug 28, 2020
Comment thread src/lib/extensions/SapphireMessage.ts
@kyranet kyranet merged commit a83b77a into main Aug 28, 2020
@kyranet kyranet deleted the feat/built-in-i18n-support branch August 28, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request: language support

5 participants