fix(core): arguments docs#44
Merged
kyranet merged 3 commits intosapphiredev:mainfrom Aug 28, 2020
Merged
Conversation
|
|
||
| /** | ||
| * The commands the framework has registered. | ||
| * The commands arguments the framework has registered. |
Rexogamer
reviewed
Aug 28, 2020
|
|
||
| /** | ||
| * The commands the framework has registered. | ||
| * The commands arguments the framework has registered. |
Contributor
There was a problem hiding this comment.
Hmm, what about
Suggested change
| * The commands arguments the framework has registered. | |
| * The command's arguments the framework has registered. |
Contributor
There was a problem hiding this comment.
Or, if it's not about a specific command
Suggested change
| * The commands arguments the framework has registered. | |
| * The command arguments the framework has registered. |
There was a problem hiding this comment.
it isn't - it's for all the arguments currently loaded. Though, arguments do not have to be command specific (?) so removing command entirely may be a better option. cc @kyranet @vladfrangu
Contributor
Author
There was a problem hiding this comment.
Yeah, I think it's a better option.
Co-authored-by: Ed L <beartechtalks@gmail.com>
kyranet
approved these changes
Aug 28, 2020
vladfrangu
approved these changes
Aug 28, 2020
Quantumlyy
approved these changes
Aug 28, 2020
Member
|
@all-contributors add @leonardssh for doc |
Contributor
|
I've put up a pull request to add @leonardssh! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.