Conversation
cfanoulis
reviewed
Aug 29, 2020
Contributor
cfanoulis
left a comment
cfanoulis
left a comment
There was a problem hiding this comment.
I don't see why we can't have sync hooks for login methods...? Also, why don't the other stages have async hooks?
Contributor
Author
Think about it... How could a constructor call async methods? |
Contributor
Author
|
Wrong button... Sorry |
kyranet
previously approved these changes
Aug 29, 2020
kyranet
previously approved these changes
Aug 29, 2020
favna
reviewed
Aug 29, 2020
favna
approved these changes
Aug 29, 2020
favna
requested changes
Aug 29, 2020
Member
favna
left a comment
favna
left a comment
There was a problem hiding this comment.
Making some local changes to other files
favna
previously approved these changes
Aug 29, 2020
kyranet
requested changes
Aug 29, 2020
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
kyranet
approved these changes
Aug 29, 2020
favna
approved these changes
Aug 29, 2020
vladfrangu
approved these changes
Aug 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.