feat(i18next): implement context and editing#35
Merged
Nytelife26 merged 8 commits intomainfrom Jan 3, 2021
Merged
Conversation
Prior to this, Message#sendTranslated would always send a new message. Now, it has been relocated to Message#translated, and an edit (boolean) parameter has been added which denotes whether to edit the message or send a new one. BREAKING CHANGE: Message#sendTranslated -> Message#translated RE #29
Message#translated was deleted following discussion with maintainers. This commit adds Message#replyTranslated, Message#editTranslated, Channel#sendTranslated, and implements full localisation context suites for all of them. It also adds an I18nContext object, which stores guilds, authors and channels to enable a per-server, per-user and per-channel localisation capacity. BREAKING CHANGE: All aforementioned changes are breaking.
Nytelife26
changed the title
kyranet
previously requested changes
Jan 3, 2021
This adds I18nGuildContext, I18nChannelContext, and I18nAuthorContext as augmentable interfaces. It also changes `#fetchLanguage` to pass the client instead of binding for performance reasons.
kyranet
previously requested changes
Jan 3, 2021
kyranet
approved these changes
Jan 3, 2021
favna
approved these changes
Jan 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the naming error previously found in i18next and also adds editing functionality.
CHANGES:
Message#sendTranslated->Message#translated(BREAKING)Message#translated:edit(boolean)