Conversation
onnozweers
changed the title
* New function is_dir() interfered with the output of create_path() * Typo was fixed in ada but should be fixed in unit test as well, to match
hailihu
requested changes
Aug 28, 2025
Contributor
hailihu
left a comment
hailihu
left a comment
There was a problem hiding this comment.
I think we need to remove the function get_locality entirely then, and replace it by is_dir. This concerns line 1438 in function bulk_request.
* The function used the /tape API call to check whether an object existed. This is not the best call to do that; the namespace call is better for that. Also, there has been a recent change in dCache that affects how this API call works, breaking Ada. * The last remaining call to this function was not really necessary, because the `case` statement below it already catches the case where a path does not exist. * Not using `is_dir` because the path might be a file... `is_dir` only returns true for a directory.
hailihu
requested changes
Sep 2, 2025
Contributor
hailihu
left a comment
hailihu
left a comment
There was a problem hiding this comment.
Looks good! Only thing is that the integration test still uses get_locatiy in test_ada_mkdir. This should be replaced with is_dir as well. I can make a commit for this and will then merge.
hailihu
deleted the
105-creating-subdirs-recursively-fails-when-parent-does-not-exist-yet
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105