102 do not create channel if folder does not exist#108
Merged
Conversation
* New function is_dir() interfered with the output of create_path() * Typo was fixed in ada but should be fixed in unit test as well, to match
* Ada now checks whether a valid, existing directory is provided * The order of validation has changed to provide more accurate error messages. When the channel name is missing, Ada will not say the path is missing, but say that the channel name and directory are missing (because if there's no channel name, the path must be missing as well)
hailihu
requested changes
Sep 2, 2025
Because the path validation calls the API and this will fail when the authentication has not been set up.
This should prevent us developers from making this mistake again.
hailihu
approved these changes
Sep 3, 2025
Contributor
hailihu
left a comment
hailihu
left a comment
There was a problem hiding this comment.
Looks good and integration test is succeeding.
Contributor
Author
|
Thanks! I like how you fixed the unit test! |
hailihu
deleted the
102-do-not-create-channel-if-folder-does-not-exist
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved validation for --events and --report-staged
Fixes #102
I cherry-picked two commits from branch #106