You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Add capture_trigger_boundary_count, and fix isSetupFrame tagging (#1)
Add capture_trigger_boundary_count, and fix isSetupFrame tagging
- New capture_trigger_boundary_count setting: with capture_trigger,
dump that many frames (or queue submissions, per
capture_trigger_boundary) each time the trigger turns on, then stop
until the trigger is turned off and on again. 0, the default, keeps
dumping while the trigger is on. Like gfxreconstruct's
capture_trigger_frames, so a capture of N frames can stop api_dump
after the same N.
- Another VkInstance created during a capture, which runs init again,
neither restarts the count nor resumes dumping after it ended.
- Under capture_trigger, nextFrame wrote the new frame's header before
refreshing the trigger, so every frame was tagged isSetupFrame from
the frame before it: the first dumped frame was tagged, and the first
frame after the trigger went off was not. The trigger is now
refreshed first.
- With capture_trigger_boundary queue_submits, frames were tagged by
checking their frame number against the queue submission range. They
are now tagged by the queue submission they start with.
- A frame object is now closed if one was opened, tracked when it is
opened, instead of recomputing that from the range or trigger state
when the frame ends. This replaces wasPreviousFrameDumped,
wasPreviousFrameRecorded and previous_frame_dumped.
- 6 new tests.
[Co-Developed using AI] Claude-opus-5.5