Dep vulnerabilities - #259
Merged
Merged
Conversation
Updates transitive dev dependencies (jest/webpack toolchain) to patched versions, bringing npm audit from 12 findings (6 high) down to 0.
Drops the reviewer-lottery GitHub Action and its config, deprecating automatic reviewer assignment on PR open.
tmoody
approved these changes
Jul 21, 2026
|
🎉 This PR is included in version 3.5.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
npm auditreported 12 vulnerabilities (6 high, 3 moderate, 3 low) in transitive dev dependencies pulled in by the jest/webpack toolchain (ajv,brace-expansion,js-yaml,minimatch,picomatch,serialize-javascript,terser-webpack-plugin,webpack,@babel/core,@babel/helpers,diff).Intent
Bring
npm auditback to a clean state without touching any production dependency behavior, and pick up the current@sasjs/corerelease for dev/test tooling while in the neighborhood.Implementation
npm audit fixto update transitive dev dependencies to patched versions — resolves all 12 findings (0 vulnerabilities remaining). Onlypackage-lock.jsonchanged; no direct dependency ranges inpackage.jsonneeded to move.@sasjs/core(dev dependency) from4.59.9to4.68.1inpackage.json/package-lock.json.src/types/targetValidators.tssurfaced bynpm run lint.Verification:
tsc --noEmitclean, full Jest suite passes (37 suites / 419 tests),npm run lintpasses,npm auditreports 0 vulnerabilities.Checks
npm run lint:fix).npm test).sasjs-cliunit tests are passing (npm test).Reviewer checks