Skip to content

fix!: Remove distinction of enum and flags-enum for ShapeTag - #65

Merged
sator-imaging merged 1 commit into
mainfrom
remove-flags-enum-distinction-shapetag-10708314756535983563
Aug 13, 2026
Merged

fix!: Remove distinction of enum and flags-enum for ShapeTag#65
sator-imaging merged 1 commit into
mainfrom
remove-flags-enum-distinction-shapetag-10708314756535983563

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

This change removes the distinction between enum and flags-enum for the ShapeTag generation, ensuring that both regular and [Flags] enums are prefixed with "enum:" in ShapeTags. It also cleans up the unused HasFlagsAttribute method from ZeroSerializerGenerator.cs, and updates corresponding assertions in ShapeTagAndHashTests.cs.


PR created automatically by Jules for task 10708314756535983563 started by @sator-imaging

Unified the ShapeTag prefix generation for regular enums and [Flags] enums under "enum:", removing the "flags:" prefix entirely and deleting the unused HasFlagsAttribute helper method. Updated the tests to match.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sator-imaging
sator-imaging marked this pull request as ready for review August 13, 2026 06:07
@sator-imaging
sator-imaging merged commit c65d08c into main Aug 13, 2026
7 checks passed
@sator-imaging
sator-imaging deleted the remove-flags-enum-distinction-shapetag-10708314756535983563 branch August 13, 2026 06:07
@sator-imaging sator-imaging changed the title Remove distinction of enum and flags-enum for ShapeTag Remove distinction of enum and flags-enum for ShapeTag Aug 13, 2026
@sator-imaging sator-imaging changed the title Remove distinction of enum and flags-enum for ShapeTag fix: Remove distinction of enum and flags-enum for ShapeTag Aug 28, 2026
@github-actions github-actions Bot added bug Something isn't working breaking-change labels Aug 28, 2026
@sator-imaging sator-imaging changed the title fix: Remove distinction of enum and flags-enum for ShapeTag fix!: Remove distinction of enum and flags-enum for ShapeTag Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant