ci: fix Intel-Mac release binary (macos-13 retired) + timeout + manual dispatch#25
Merged
Merged
Conversation
… dispatch The x86_64-apple-darwin binary was built on `macos-13`, which GitHub is retiring: the job sat unscheduled until the 24h workflow cap and was cancelled, so the Intel-Mac tarball was missing from every release (v0.1.0, v0.1.1) and each release run showed "cancelled". - Cross-compile x86_64-apple-darwin on the Apple-Silicon `macos-latest` runner (drops the retired macos-13 dependency). - `timeout-minutes: 20` so a stuck runner fails fast instead of hanging a day. - Add `workflow_dispatch` (build + package every target, upload guarded to tag pushes only) so releases can be validated before they're cut. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=======================================
Coverage 73.09% 73.09%
=======================================
Files 31 31
Lines 9002 9002
=======================================
Hits 6580 6580
Misses 2422 2422
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Prebuilt binaries are already wired (this
release.ymlbuildscodeoid-tuiand uploads to the release release-plz creates) — but the Intel-Mac binary has been silently missing from every release, and each release run showed "cancelled" after 24h.Root cause: the
x86_64-apple-darwinjob ran onmacos-13, which GitHub is retiring. The job sat unscheduled until the 24-hour workflow cap and was cancelled — confirmed on both prior releases:Fix
x86_64-apple-darwinon the Apple-Siliconmacos-latestrunner — drops the retiredmacos-13dependency (Apple Silicon cross-compiles to x86_64 cleanly).timeout-minutes: 20— a stuck/retired runner now fails fast instead of hanging to the 24h cap.workflow_dispatch— a manual build-only run (upload guarded to tag pushes viaif: startsWith(github.ref, 'refs/tags/')) so a release can be validated before it's cut.How it coexists with release-plz (unchanged)
release-plz owns version + CHANGELOG + crates.io publish + the tag + GitHub Release creation; this workflow only builds + uploads binaries to that release on the tag. No overlap, no cargo-dist needed.
Merge this before merging the release-plz PR (#13). release-plz pushes the
v0.2.0tag usingrelease.ymlas it exists onmainat that moment — so this fix must be onmainfirst for the Intel-Mac binary to build. After merging, you can optionally triggerrelease.ymlvia workflow_dispatch to confirm all three targets build before cutting v0.2.0.🤖 Generated with Claude Code