Skip to content

Add ImpersonationAlert component and improve styling consistency - #36

Merged
roble merged 2 commits into
mainfrom
dev
Apr 15, 2026
Merged

Add ImpersonationAlert component and improve styling consistency#36
roble merged 2 commits into
mainfrom
dev

Conversation

@roble

@roble roble commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

This pull request introduces a new impersonation alert feature and makes several UI consistency improvements across authentication-related components. The most significant change is the addition of the ImpersonationAlert component, which provides a user interface for impersonation sessions. Additionally, several minor updates were made to improve class naming consistency and formatting in various authentication forms.

New Impersonation Alert Feature:

  • Added a new ImpersonationAlert.vue component that displays an alert when impersonating another user, including user details, a quick action to end/reimpersonate, and a recent history list. The component handles user interactions such as expanding/collapsing, clicking outside, and keyboard events.
  • Registered the ImpersonationAlert component globally in the app initialization, ensuring it is available throughout the application. [1] [2]

UI Consistency Improvements:

  • Standardized button and link class orderings (e.g., text-primary, font-medium, underline-offset-4, hover:underline) for better visual consistency in Login.vue, Register.vue, VerifyEmail.vue, and related components. [1] [2] [3] [4] [5]
  • Improved formatting and class usage in authentication layouts and forms, including AuthCardLayout.vue, ForgotPassword.vue, and MagicLink.vue, for better readability and maintainability. [1] [2] [3] [4] [5]
  • Minor class name adjustment for the "Last used" badge in SocialiteProviders.vue for improved styling consistency.

These changes collectively enhance the authentication experience and maintain a consistent, maintainable codebase.

Copilot AI review requested due to automatic review settings April 14, 2026 19:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a global impersonation-session UI alert and standardizes styling/formatting across auth-related Vue pages/components.

Changes:

  • Introduced ImpersonationAlert.vue to show active impersonation details and recent impersonation history with quick actions.
  • Registered the alert as a global component during auth module setup.
  • Normalized class ordering and improved template formatting in several authentication pages/layouts/components.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
resources/js/components/ImpersonationAlert.vue New component implementing the impersonation alert UI, interactions (expand/collapse, click-outside, Escape), and re-impersonation action.
resources/js/app.ts Registers the new global impersonation alert component during module setup.
resources/js/pages/Login.vue Reorders/standardizes link/button utility classes for consistency.
resources/js/pages/Register.vue Reorders/standardizes link utility classes for consistency.
resources/js/pages/VerifyEmail.vue Reorders/standardizes logout link utility classes for consistency.
resources/js/pages/MagicLink.vue Formatting improvements (multiline props, attribute wrapping) for readability.
resources/js/pages/ForgotPassword.vue Formatting improvements (attribute wrapping) for readability.
resources/js/layouts/AuthCardLayout.vue Formatting improvements for readability (multiline bindings and indentation).
resources/js/components/SocialiteProviders.vue Import ordering and minor badge class ordering consistency update.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread resources/js/components/ImpersonationAlert.vue
@roble
roble merged commit 2e72ca5 into main Apr 15, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants