Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a global impersonation-session UI alert and standardizes styling/formatting across auth-related Vue pages/components.
Changes:
- Introduced
ImpersonationAlert.vueto show active impersonation details and recent impersonation history with quick actions. - Registered the alert as a global component during auth module setup.
- Normalized class ordering and improved template formatting in several authentication pages/layouts/components.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| resources/js/components/ImpersonationAlert.vue | New component implementing the impersonation alert UI, interactions (expand/collapse, click-outside, Escape), and re-impersonation action. |
| resources/js/app.ts | Registers the new global impersonation alert component during module setup. |
| resources/js/pages/Login.vue | Reorders/standardizes link/button utility classes for consistency. |
| resources/js/pages/Register.vue | Reorders/standardizes link utility classes for consistency. |
| resources/js/pages/VerifyEmail.vue | Reorders/standardizes logout link utility classes for consistency. |
| resources/js/pages/MagicLink.vue | Formatting improvements (multiline props, attribute wrapping) for readability. |
| resources/js/pages/ForgotPassword.vue | Formatting improvements (attribute wrapping) for readability. |
| resources/js/layouts/AuthCardLayout.vue | Formatting improvements for readability (multiline bindings and indentation). |
| resources/js/components/SocialiteProviders.vue | Import ordering and minor badge class ordering consistency update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new impersonation alert feature and makes several UI consistency improvements across authentication-related components. The most significant change is the addition of the
ImpersonationAlertcomponent, which provides a user interface for impersonation sessions. Additionally, several minor updates were made to improve class naming consistency and formatting in various authentication forms.New Impersonation Alert Feature:
ImpersonationAlert.vuecomponent that displays an alert when impersonating another user, including user details, a quick action to end/reimpersonate, and a recent history list. The component handles user interactions such as expanding/collapsing, clicking outside, and keyboard events.ImpersonationAlertcomponent globally in the app initialization, ensuring it is available throughout the application. [1] [2]UI Consistency Improvements:
text-primary,font-medium,underline-offset-4,hover:underline) for better visual consistency inLogin.vue,Register.vue,VerifyEmail.vue, and related components. [1] [2] [3] [4] [5]AuthCardLayout.vue,ForgotPassword.vue, andMagicLink.vue, for better readability and maintainability. [1] [2] [3] [4] [5]SocialiteProviders.vuefor improved styling consistency.These changes collectively enhance the authentication experience and maintain a consistent, maintainable codebase.