Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Taskfile entry intended to standardize generating TypeScript declaration types for the Settings module from PHP DTOs/enums.
Changes:
- Added a
types:generateTaskfile task that runsphp artisan module:generate-types Settings. - Added
resources/js/types/generated.d.tsas the expected output location for generated TypeScript declarations.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Taskfile.yml | Adds a dedicated task to run the Settings type-generation artisan command. |
| resources/js/types/generated.d.ts | Introduces the generated TypeScript declaration file intended to hold DTO/enum typings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new code generation task to the
Taskfile.yml, making it easier to generate TypeScript types from PHP DTOs and enums for the Settings module.Code Generation:
types:generatetask that runsphp artisan module:generate-types Settingsto generate TypeScript types from PHP DTOs and enums.