Demo deletion#1923
Merged
Merged
Conversation
### What's done: * Implemented demo deletion * Added frontend button that would delete demo * Added ttlSecondsAfterFinished to s3-deployment.yaml in order to clean the startup job (minio-create-bucket) (#1922)
sanyavertolet
added
enhancement
sanyavertolet
requested review from
0x6675636b796f75676974687562,
kgevorkyan,
nulls and
orchestr7
March 2, 2023 12:32
sanyavertolet
enabled auto-merge (squash)
March 2, 2023 12:33
Codecov Report
@@ Coverage Diff @@
## master #1923 +/- ##
============================================
- Coverage 34.24% 34.11% -0.14%
Complexity 591 591
============================================
Files 312 312
Lines 7805 7836 +31
Branches 752 755 +3
============================================
Hits 2673 2673
- Misses 4944 4975 +31
Partials 188 188
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nulls
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #1922
What's done:
ttlSecondsAfterFinishedtos3-deployment.yamlin order to clean the startup job (minio-create-bucket)