Remove the Spec.Event class; Spec.Assert has all the info we need.#10
Merged
Remove the Spec.Event class; Spec.Assert has all the info we need.#10
Spec.Event class; Spec.Assert has all the info we need.#10Conversation
After all the refactoring of how assertions work, `Spec.Assert` now contains everything that was held by `Spec.Event` (and more) so there is no reason to keep `Spec.Event` around as a wrapper for `Spec.Assert`.
This was referenced Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After all the refactoring of how assertions work,
Spec.Assertnow contains everything that was held by
Spec.Event(and more)so there is no reason to keep
Spec.Eventaround as a wrapper forSpec.Assert.