Rename event to assertion throughout the code (including plural f…

[mneumann]

…orms)

Reflecting the change introduced in PR #10 which replaced Spec.Event by Spec.Assert.

We should actually also rename Spec.Assert to Spec.Assertion or is Assert a noun?

[jemc]

Looks good.

Regarding the question of Spec.Assert vs Spec.Assertion I have no strong opinion on the matter, but given that this PR uses assertion everywhere, then yes we should probably use Spec.Assertion for the class name.

[mneumann]

Looks good.

Regarding the question of Spec.Assert vs Spec.Assertion I have no strong opinion on the matter, but given that this PR uses assertion everywhere, then yes we should probably use Spec.Assertion for the class name.

The savi compiler generates instances of Spec.Assert for assert: macros, so we would first have to change this. I am leaving this as is for now.

[jemc]

The savi compiler generates instances of Spec.Assert for assert: macros, so we would first have to change this. I am leaving this as is for now.

Yeah, we need to figure out how to clean that up properly.

I don't have any ideas that I'm really sure about, but my best idea at the moment is:

• Finish getting the manifest-handling code working for allowing a package to export more than one top-level type name (but still encourage most packages to use just one).
• Add an Assert type to the Spec package (with no Spec. prefix), which creates a Spec.Assertion when called.
• Make the assert macro always use the Assert type instead of Spec.Assert, allowing potentially any library to export a type named Assert that gets used for assertions within the packages that allow it to be the exporter of that name (remembering that in the design of Savi's namespacing each manifest is meant to govern what names go to which providing packages within the source files of a package defined by that manifest - so it is possible to have Assert be provided by the Spec package in some package source files, while having it be provided by some other package (for example, one providing runtime assertions of some kind) in other source files).