v3.3.0.2 — apostrophe search returned wrong results - #59
Merged
Conversation
Version, plugin manifest, CHANGELOG and landing page for the two bug fixes merged from the May/June Jules PR queue (#33, #48). #33 is the one that matters to users: bin/idstack-learnings-search spliced $SOURCES/$TYPE/$KEYWORD/$LIMIT into Python source, so searching for a term with an apostrophe raised SyntaxError, got swallowed by 2>/dev/null, and fell through to a grep fallback with no --type filter. Reproduced on main before merging: $ idstack-learnings-search --keyword "Bloom's" --type technical {"key":"blooms-note","type":"operational",...} <- wrong type, no error Same defect class v3.3.0.0 fixed in bin/idstack-status; that pass missed this file. #48 adds the isinstance(dict) guard load_payload lacked while load_manifest had one, so a bare JSON array merged in and surfaced later as an AttributeError inside idstack-status --readiness. Verified: smoke 371/371, integration 25/25, setup 17/17, manifest-merge 23/23, version-classifier 27/27, plugin-status 9/9, preamble-python 6/6, mutations 14/14 guarded. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release commit for the two bug fixes merged out of the stale Jules PR queue (#33, #48).
The user-facing one (#33)
bin/idstack-learnings-searchspliced$SOURCES/$TYPE/$KEYWORD/$LIMITstraight into Python source. Reproduced on main before merging:The apostrophe makes the generated Python a SyntaxError,
2>/dev/nullswallows it, and execution falls through to a grep fallback that has no--typefilter. So it answers wrongly rather than failing. "Bloom's" and "learner's" are ordinary search terms in this tool.Same defect class v3.3.0.0 fixed in
bin/idstack-status— that pass missed this file.The quieter one (#48)
load_manifesthad anisinstance(data, dict)guard andload_payloaddidn't, so a bare JSON array merged in cleanly and surfaced much later asAttributeError: 'list' object has no attribute 'get'insideidstack-status --readiness.Verification
CI had never run on either PR branch, so both were merged locally onto current main and the full suite run before landing.
🤖 Generated with Claude Code