feat(desktop): keyboard nav, full TUI feature parity, notebook import polish - #82
Merged
Merged
Conversation
…port polish Brings shiki-desktop up to feature parity with the TUI: keyboard-driven mode/focus/overlay state machine (which-key, global search, outline, tags, tree, query, git dashboard, tasks, links, history, logs, settings, theme picker, drawer), a mock backend so the whole UI is drivable in a plain browser tab without the native shell, and every previously-missing action (scratchpad, visual-mode batch ops, external editor, working-diff view, export/publish, notebook rename/delete/pull). Also fixes two real bugs and adds the notebook-creation improvements requested this session: - Theme selection didn't persist: `AppState.config` was loaded once at process startup and never mutated in memory, so `set_theme`/ `save_full_config`/`toggle_favorite_editor` wrote config.toml correctly but any webview reload that didn't restart the whole process kept showing the stale in-memory theme. `config`/`store` are now `Mutex`-wrapped with `update_config`/`register_custom_path` as the one place a change touches memory and disk together. - New-notebook flow: pasting a git URL now auto-detects and clones (mirrors the TUI's `create_notebook_from_url`, reusing whatever git credentials are already configured — no OAuth setup needed), and a new "Import an existing folder…" action opens the real native OS folder picker (`tauri-plugin-dialog`) and adopts it as a notebook, confirming before initializing git if the folder doesn't have a repo yet. The onboarding screen's previously-disconnected "Import" stub now uses this same real flow instead of a placeholder message. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
CI's fmt+clippy check failed on the previous commit's formatting. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppState.config/storewere loaded once at process startup and never mutated in memory, so a webview reload that didn't restart the whole process kept showing stale data even though config.toml was written correctly. Both are nowMutex-wrapped with a singleupdate_config/register_custom_pathpath that keeps memory and disk in sync.tauri-plugin-dialog), confirming before initializing git if needed. The onboarding screen's previously-disconnected "Import" stub now uses this same real flow.Test plan
cargo check -p shiki-desktop/cargo clippy -p shiki-desktop --all-targetscleantsc --noEmit/npm run buildclean🤖 Generated with Claude Code