Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v21.1.8
Click here for the full clang-format patch
diff --git a/Sources/CSFBAudioEngine/Player/AudioPlayer.mm b/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
index f7251b3..132bd8e 100644
--- a/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
+++ b/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
@@ -2107,2 +2107,2 @@ void sfb::AudioPlayer::handleRenderingWillCompleteEvent(Decoder decoder, uint64_
- if (didStopEngine &&
- [player.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) {
+ if (didStopEngine && [player.delegate respondsToSelector:@selector(audioPlayer:
+ playbackStateChanged:)]) {
Have any feedback or feature suggestions? Share it here.
Comment on lines
+2107
to
+2108
| if (didStopEngine && | ||
| [player.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) { |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| if (didStopEngine && | |
| [player.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) { | |
| if (didStopEngine && [player.delegate respondsToSelector:@selector(audioPlayer: | |
| playbackStateChanged:)]) { |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the risk of use-after-free during the “rendering complete” async notification path by ensuring delegate callbacks use the block’s strongly-retained SFBAudioPlayer *player rather than the AudioPlayer’s weak player_ back-pointer.
Changes:
- Use the strong local
playerreference (promoted fromweakPlayer) forplaybackStateChanged:delegate notifications in the rendering-complete dispatch block. - Minor formatting cleanup of the
@selector(audioPlayer:playbackStateChanged:)check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v21.1.8
Click here for the full clang-format patch
diff --git a/Sources/CSFBAudioEngine/Player/AudioPlayer.mm b/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
index 2e3b3c5..132bd8e 100644
--- a/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
+++ b/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
@@ -667,2 +667,2 @@ bool sfb::AudioPlayer::play(NSError **error) noexcept {
- if ((didStartEngine || !wasPlaying) &&
- [player_.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) {
+ if ((didStartEngine || !wasPlaying) && [player_.delegate respondsToSelector:@selector(audioPlayer:
+ playbackStateChanged:)]) {
@@ -1786,2 +1786,2 @@ bool sfb::AudioPlayer::processDecoderCanceledEvent() noexcept {
- } else if (error != nil &&
- [player_.delegate respondsToSelector:@selector(audioPlayer:decodingAborted:error:framesRendered:)]) {
+ } else if (error != nil && [player_.delegate respondsToSelector:@selector(audioPlayer:
+ decodingAborted:error:framesRendered:)]) {
@@ -2107,2 +2107,2 @@ void sfb::AudioPlayer::handleRenderingWillCompleteEvent(Decoder decoder, uint64_
- if (didStopEngine &&
- [player.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) {
+ if (didStopEngine && [player.delegate respondsToSelector:@selector(audioPlayer:
+ playbackStateChanged:)]) {
@@ -2247,2 +2247,2 @@ void sfb::AudioPlayer::handleAudioSessionInterruption(NSDictionary *userInfo) no
- if (preInterruptState_ != 0 &&
- [player_.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) {
+ if (preInterruptState_ != 0 && [player_.delegate respondsToSelector:@selector(audioPlayer:
+ playbackStateChanged:)]) {
Have any feedback or feature suggestions? Share it here.
Comment on lines
+667
to
+668
| if ((didStartEngine || !wasPlaying) && | ||
| [player_.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) { |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| if ((didStartEngine || !wasPlaying) && | |
| [player_.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) { | |
| if ((didStartEngine || !wasPlaying) && [player_.delegate respondsToSelector:@selector(audioPlayer: | |
| playbackStateChanged:)]) { |
Comment on lines
+1786
to
+1787
| } else if (error != nil && | ||
| [player_.delegate respondsToSelector:@selector(audioPlayer:decodingAborted:error:framesRendered:)]) { |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| } else if (error != nil && | |
| [player_.delegate respondsToSelector:@selector(audioPlayer:decodingAborted:error:framesRendered:)]) { | |
| } else if (error != nil && [player_.delegate respondsToSelector:@selector(audioPlayer: | |
| decodingAborted:error:framesRendered:)]) { |
Comment on lines
+2107
to
+2108
| if (didStopEngine && | ||
| [player.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) { |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| if (didStopEngine && | |
| [player.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) { | |
| if (didStopEngine && [player.delegate respondsToSelector:@selector(audioPlayer: | |
| playbackStateChanged:)]) { |
Comment on lines
+2247
to
+2248
| if (preInterruptState_ != 0 && | ||
| [player_.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) { |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| if (preInterruptState_ != 0 && | |
| [player_.delegate respondsToSelector:@selector(audioPlayer:playbackStateChanged:)]) { | |
| if (preInterruptState_ != 0 && [player_.delegate respondsToSelector:@selector(audioPlayer: | |
| playbackStateChanged:)]) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.