Defer to user's truffle config / add coverage network #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add new truffle config handling * use ifs * nework typo lol * remove stray config edits * remove truffleConfig.js, improve default config handling * readability * remove legacy truffle config file, don't rely on truffle's fallback strategy * add semicolon * eh, no need to explicitly remove this * fix notes, simplify logic * debug e2e * print pr path * update pr_path * use commit sha1 * update pr path in other e2e, remove log * Adapt PR_PATH for cached builds * Debug CI
Fix CI for forks
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 6 6
Lines 372 372
Branches 79 79
=======================================
Hits 341 341
Misses 31 31Continue to review full report at Codecov.
|
cgewecke
force-pushed
the
stage/truffle-config-handling
branch
from
5f25978 to
1c49cc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #366
This PR includes fixes to CI for PRs originating from forks (#367)