Automatically add Scala nature when opening Play2 Template editor #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java Play2 Template project don't have the Scala nature by default, and this caused an exception to be thrown whenever the user tried to open a Play2 Template editor because the editor needs access to the ``ScalaProject`` facilities. The implemented solution is to automatically add the Scala nature if a project doesn't have it. Note that ``TemplateCompilationUnit.scalaProject`` is no longer ``lazy`` because I want the code to fail fast if a ``ScalaProject`` cannot be created. Fix scala-ide#33
* Removed unused import in ``RouteTestSuite``. * Added explicit return type on public methods. * Remove comment in POM about Play 2.0.x support.
|
LGTM |
dotta
added a commit
that referenced
this pull request
Apr 4, 2013
Automatically add Scala nature when opening Play2 Template editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java Play2 Template project don't have the Scala nature by default, and this
caused an exception to be thrown whenever the user tried to open a Play2
Template editor because the editor needs access to the
ScalaProjectfacilities.
The implemented solution is to automatically add the Scala nature if a project
doesn't have it.
Note that
TemplateCompilationUnit.scalaProjectis no longerlazybecause I want the code to fail fast if a
ScalaProjectcannot be created.Fix #33