Create two distinct scalafix rules targeting 2.12 and 2.13 #352
Conversation
| collectionsScalaVersionSettings, | ||
| fork in Test := true, | ||
| javaOptions in Test += "-Xss1M", | ||
| libraryDependencies ++= Seq( |
There was a problem hiding this comment.
Also, a side-effect of the changes in this file is that the project can be imported without errors in IntelliJ.
|
What do you think would be the most convenient to support different directories for rules without missing |
|
I wouldn’t put in scalafix something that specific to the collection-strawman project. Also, I’m not sure I will keep the 2.12 rewrite because it is super hard to get right (because of we have to unimport several default imports) |
|
|
||
| def replaceCopyToBuffer(ctx: RuleCtx): Patch = | ||
| ctx.tree.collect { | ||
| case t @ q"${copyToBuffer(Term.Select(collection, _))}($buffer)" => |
There was a problem hiding this comment.
Pro tip, you can put the collection qualifier like this to avoid Term.Select
@ val q"$qual.${q"foo"}(..$arg)" = q"qual.foo(1, 2)"
qual: Term = Term.Name("qual")
arg: List[Term] = List(Lit.Int(1), Lit.Int(2))
People have different tastes however, I personally prefer Term.Select :)
2 participants
I created two subdirectories,
scalafix/2.12andscalafix/2.13to support two kinds of rules: (1) migration from a 2.12 code base to a 2.12 code base using the strawman as a library, and (2) migration of a 2.12 code base to a 2.13 code base (where the standard collection is the strawman).A consequence is that I can not anymore use the nice
githubscheme in scalafix URLs (see here) but the 2.12 and 2.13.cc @olafurpg.