This repository was archived by the owner on Feb 20, 2019. It is now read-only.
Adding static-only switch to pickling #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Odd, this builds and tests run successfully on my machine... |
There was a problem hiding this comment.
Let's move those to src/test/scala, since they're test-only.
There was a problem hiding this comment.
Yeah, that's what I thought. I left it there though because I was following what you guys did in async – I was wondering why this stuff wasn't in test for you...
There was a problem hiding this comment.
Async has it in src/test/scala though: https://github.com/scala/async/blob/master/src/test/scala/scala/async/package.scala
|
LGTM |
heathermiller
added a commit
that referenced
this pull request
Aug 5, 2014
Adding static-only switch to pickling
heathermiller
added a commit
that referenced
this pull request
Feb 5, 2015
Adding static-only switch to pickling
phaller
pushed a commit
to phaller/pickling
that referenced
this pull request
Jul 27, 2015
Adding static-only switch to pickling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.