-
Notifications
You must be signed in to change notification settings - Fork 332
Add information about Metals to scala-lang website and replace Ensime #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jvican
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job @tgodzik 👍
|
What about moving Eclipse to the last position? I'm not sure how often Eclipse is used but given that not many developers are using it according to the Stack Overflow developer surveys we should most likely demote its visibility. |
I am ok with that. Any other opinions? |
olafurpg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment on the tooltip message, otherwise this looks great! @tgodzik Thank you for working on this 🙏
olafurpg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
olafurpg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we link to the installation docs instead of the editor websites?
I was thinking about it, but we previously pointed to the editor pages themselves - might make sense to change that |
…intained plus add Emacs and VIM as support Co-Authored-By: Ólafur Páll Geirsson <olafurpg@gmail.com>
dwijnand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanking Ensime and the Ensime maintainers for the editor support provided over many years, I agree it makes sense to update the website to link to (and promote) Metals.
That should be said by me 🤦♂️ Very sorry for being undiplomatic. It goes without saying that Ensime was an awesome project and proved that tooling can be cool 🚀 |

Replace Ensime logo with Metals since Ensime is no longer actively maintained and add all supported editors for Metals.