Skip to content

Conversation

@tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jun 27, 2019

Replace Ensime logo with Metals since Ensime is no longer actively maintained and add all supported editors for Metals.

image

Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job @tgodzik 👍

@jvican
Copy link
Member

jvican commented Jun 27, 2019

What about moving Eclipse to the last position? I'm not sure how often Eclipse is used but given that not many developers are using it according to the Stack Overflow developer surveys we should most likely demote its visibility.

@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 27, 2019

What about moving Eclipse to the last position? I'm not sure how often Eclipse is used but given that not many developers are using it according to the Stack Overflow developer surveys we should most likely demote its visibility.

I am ok with that. Any other opinions?

@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 28, 2019

Moved Eclipse back:
image

Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment on the tooltip message, otherwise this looks great! @tgodzik Thank you for working on this 🙏

Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we link to the installation docs instead of the editor websites?

@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 28, 2019

How about we link to the installation docs instead of the editor websites?

I was thinking about it, but we previously pointed to the editor pages themselves - might make sense to change that

…intained plus add Emacs and VIM as support

Co-Authored-By: Ólafur Páll Geirsson <olafurpg@gmail.com>
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanking Ensime and the Ensime maintainers for the editor support provided over many years, I agree it makes sense to update the website to link to (and promote) Metals.

@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 28, 2019

Thanking Ensime and the Ensime maintainers for the editor support provided over many years, I agree it makes sense to update the website to link to (and promote) Metals.

That should be said by me 🤦‍♂️ Very sorry for being undiplomatic. It goes without saying that Ensime was an awesome project and proved that tooling can be cool 🚀

@dwijnand dwijnand merged commit 4b422b1 into scala:master Jun 28, 2019
@tgodzik tgodzik deleted the add-metals branch June 28, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants