Skip to content

Fix Jekyll exit status for Travis #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarrodu merged 1 commit into from
Nov 17, 2016
+3 −1
Merged

Fix Jekyll exit status for Travis #537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,6 @@ install:
- bundle install

script:
- bundle exec jekyll build
- bundle exec jekyll build 2> error.log
- cat >&2 error.log
Copy link
Member

@jarrodu jarrodu Nov 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under what conditions will this line exit with a non-zero status?

Copy link
Member

@jarrodu jarrodu Nov 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what I am getting at is I don't understand what the >&2 is for.

Copy link
Member Author

@ashawley ashawley Nov 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2> pipes stderr to error.log

The >&2 pipes stdout to stderr

I guess what I am getting at is I don't understand what the >&2 is for.

It makes the font of the error message "Yellow" in Travis?

Copy link
Member

@jarrodu jarrodu Nov 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay >&2 is starting to make more sense.

But why cat >&2 error.log instead of cat error.log >&2.

Thanks for your time. I know your job is not to spend all day educating me. ;-)

Copy link
Member Author

@ashawley ashawley Nov 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, no difference. Let me know if >&2 at the end is clearer.

Thank you for the careful review!

- ( ! grep -qie Error error.log )